Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpha masking module #1546

Merged
merged 17 commits into from
Nov 3, 2020
Merged

Alpha masking module #1546

merged 17 commits into from
Nov 3, 2020

Conversation

rishabhshuklax
Copy link
Member

@rishabhshuklax rishabhshuklax commented Jan 20, 2020 •
edited
Loading

Concerns #165

This PR adds Alpha Masking module!

Screenshot from 2020-01-20 19-43-22

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 20, 2020 •
edited
Loading

Codecov Report

Merging #1546 into main will decrease coverage by 1.51%.
The diff coverage is 52.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
- Coverage   66.67%   65.16%   -1.52%     
==========================================
  Files         130      137       +7     
  Lines        2686     2862     +176     
  Branches      433      462      +29     
==========================================
+ Hits         1791     1865      +74     
- Misses        895      997     +102
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/Shadow/Module.js 44.30% <44.30%> (ø)
src/modules/Mask/Module.js 87.87% <87.87%> (ø)
src/modules/Overlay/Module.js 93.18% <94.11%> (-1.69%) ⬇️
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js 100.00% <100.00%> (ø)
src/modules/Crop/Module.js 88.88% <100.00%> (ø)
... and 12 more

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers please review this!

This was referenced Jan 20, 2020
Open
Closed
jywarren
jywarren requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Is it possible to add a module test here? Thanks a lot!

@rishabhshuklax
Copy link
Member Author

@jywarren tests added 😄

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2020 •
edited
Loading

@jywarren
Copy link
Member

jywarren commented Aug 5, 2020

This looks awesome. Catching up on the PRs now due to GitPod speeding up review! Thank you!!!

jywarren
jywarren requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, i'm so sorry, there is just one thing. Is it possible to use a flat file for the test? The inline data-url is just too gigantic. I think other tests show how to do this pretty well. Alternatively if you get really stuck, you could require() in the image from a separate file so the tests themselves are readable. Thank you!

src/modules/Mask/info.json
@@ -0,0 +1,18 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nicely done. Well formatted, readable, excellent work!

@jywarren
Copy link
Member

jywarren commented Aug 6, 2020

Just confirming this works great in GitPod!

image

@jywarren
Copy link
Member

jywarren commented Nov 1, 2020

Noting #flat

Hi, i'm so sorry, there is just one thing. Is it possible to use a flat file for the test? The inline data-url is just too gigantic. I think other tests show how to do this pretty well. Alternatively if you get really stuck, you could require() in the image from a separate file so the tests themselves are readable. Thank you!

Noting we can address this in #1502

This should be good!

@jywarren jywarren requested a review from a team as a code owner November 1, 2020 19:43
@jywarren jywarren requested review from a team as code owners November 1, 2020 19:43
jywarren
jywarren approved these changes Nov 1, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Getting ready to merge this.

@jywarren jywarren requested a review from a team November 1, 2020 19:47
harshkhandeparkar
harshkhandeparkar approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Used the Github CLI. It is awesome!

@jywarren jywarren mentioned this pull request Nov 3, 2020
Draft
5 tasks
@jywarren jywarren merged commit f0cb35a into publiclab:main Nov 3, 2020
@jywarren
Copy link
Member

jywarren commented Nov 3, 2020

Hooray!!!!!

@harshkhandeparkar harshkhandeparkar mentioned this pull request Jan 14, 2021
Closed
11 tasks
This was referenced Jan 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshkhandeparkar harshkhandeparkar harshkhandeparkar approved these changes

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishabhshuklax @jywarren @harshkhandeparkar